Re: [PATCH] Document core.excludesfile for git-add

Thanks, but wouldn't this belong to Documentation/config.txt
instead, I wonder?

On Wed, May 16, 2007 at 10:31:12PM -0700, Junio C Hamano wrote:

Thanks, but wouldn't this belong to Documentation/config.txt
instead, I wonder?

It appears to my untrained eye that core.excludesfiles only works for
git-add.  It seems to have no effect on git-status and the only code
that mentions core.excludesfile is builtin-add.c

-- 
Michael

On Thu, May 17, 2007 at 04:35:44PM CEST, Michael Hendricks wrote:

On Wed, May 16, 2007 at 10:31:12PM -0700, Junio C Hamano wrote:

quoted

Thanks, but wouldn't this belong to Documentation/config.txt
instead, I wonder?

It appears to my untrained eye that core.excludesfiles only works for
git-add.  It seems to have no effect on git-status and the only code
that mentions core.excludesfile is builtin-add.c

I believe the current policy should be that all config options are at
least briefly listed in config.txt and possibly are described in more
detail in the documentation of relevant command.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett

On Thursday 17 May 2007, Michael Hendricks wrote:

On Wed, May 16, 2007 at 10:31:12PM -0700, Junio C Hamano wrote:

quoted

Thanks, but wouldn't this belong to Documentation/config.txt
instead, I wonder?

It appears to my untrained eye that core.excludesfiles only works for
git-add.  It seems to have no effect on git-status and the only code
that mentions core.excludesfile is builtin-add.c

If so, we should probably fix that. The set of ignore files parsed by 
relevant git commands should be consistent. We don't want a situation 
where exclude patterns in a file are picked up by some git commands, but
not by others.

...Johan

-- 
Johan Herland, [off-list ref]
www.herland.net