Re: [PATCH] gitweb: Fix few 'use of undefined value' warnings

Petr Baudis [off-list ref] writes:

On Fri, Apr 27, 2007 at 06:43:53PM CEST, Petr Baudis wrote:

quoted

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index b67ce41..b51103e 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl

@@ -1057,6 +1058,7 @@ sub git_get_project_description {
 	open my $fd, "$projectroot/$path/description" or return undef;
 	my $descr = <$fd>;
 	close $fd;
+	$descr or return undef;
 	chomp $descr;
 	return $descr;
 }

It looks like this hunk has been skipped...?

It is more like the whole messages was missed, and then 198a2a8a
and others tried to do the same thing but missed this one.

On Thu, May 17, 2007 at 06:05:06AM CEST, Junio C Hamano wrote:

Petr Baudis [off-list ref] writes:

quoted

On Fri, Apr 27, 2007 at 06:43:53PM CEST, Petr Baudis wrote:

quoted

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index b67ce41..b51103e 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl

@@ -1057,6 +1058,7 @@ sub git_get_project_description {
 	open my $fd, "$projectroot/$path/description" or return undef;
 	my $descr = <$fd>;
 	close $fd;
+	$descr or return undef;
 	chomp $descr;
 	return $descr;
 }

It looks like this hunk has been skipped...?

It is more like the whole messages was missed, and then 198a2a8a
and others tried to do the same thing but missed this one.

Oh, aha - I thought that it was applied when you replied "thanks"...

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett