Re: [PATCH] cvsserver: Don't send mixed messages to clients

Frank Lichtenheld [off-list ref] writes:

After looking through all the uses of
	die "something"
and
	print "E something";
	exit;
and
	print "error 1 something";
	exit;

in the current code I fail to see a real pattern there, is there any?
If yes, we should maybe document it in a comment somewhere...

For the record, cvs (server side) does the following in this particular situation:
	buf_output0 (buf_to_net, "I HATE YOU\n");
        buf_flush (buf_to_net, true);

        /* Don't worry about server_cleanup, server_active isn't set
           yet.  */
        exit (EXIT_FAILURE);

Ok, I stand corrected.  If there is a pattern to emulate, that
should be found in the real cvs server.

On Mon, May 14, 2007 at 02:28:29PM -0700, Junio C Hamano wrote:

Frank Lichtenheld [off-list ref] writes:

quoted

For the record, cvs (server side) does the following in this particular situation:
	buf_output0 (buf_to_net, "I HATE YOU\n");
        buf_flush (buf_to_net, true);

        /* Don't worry about server_cleanup, server_active isn't set
           yet.  */
        exit (EXIT_FAILURE);

Ok, I stand corrected.  If there is a pattern to emulate, that
should be found in the real cvs server.

Will you correct the patch then back to my version? master still has
your version of it AFAICT.

Gruesse,
-- 
Frank Lichtenheld [off-list ref]
www: http://www.djpig.de/