Re: [PATCH (amend)] cvsserver: Add test cases for config file handling

3 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH (amend)] cvsserver: Add test cases for config file handling

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:10

Frank Lichtenheld [off-list ref] writes:
Add a few test cases for the config file parsing
done by git-cvsserver.

Signed-off-by: Frank Lichtenheld <redacted>
---
 t/t9420-git-cvsserver-config.sh |  109 +++++++++++++++++++++++++++++++++++++++
 1 files changed, 109 insertions(+), 0 deletions(-)
 create mode 100755 t/t9420-git-cvsserver-config.sh
Do we really need a separate test script that does quite similar setup?

Re: [PATCH (amend)] cvsserver: Add test cases for config file handling

From: Frank Lichtenheld <hidden>
Date: 2016-06-15 22:43:10

On Sun, May 13, 2007 at 01:04:15PM -0700, Junio C Hamano wrote:
Frank Lichtenheld [off-list ref] writes:
quoted
Add a few test cases for the config file parsing
done by git-cvsserver.

Signed-off-by: Frank Lichtenheld <redacted>
---
 t/t9420-git-cvsserver-config.sh |  109 +++++++++++++++++++++++++++++++++++++++
 1 files changed, 109 insertions(+), 0 deletions(-)
 create mode 100755 t/t9420-git-cvsserver-config.sh
Do we really need a separate test script that does quite similar setup?
Right now, probably not.

But I certainly don't intend to do all the tests in one big file which
will become rather large over time. If you're concerned with code
duplication, maybe I should move the code to a separate file and source
it from there?

Gruesse,
-- 
Frank Lichtenheld [off-list ref]
www: http://www.djpig.de/

Re: [PATCH (amend)] cvsserver: Add test cases for config file handling

From: Frank Lichtenheld <hidden>
Date: 2016-06-15 22:43:11

On Mon, May 14, 2007 at 02:59:16PM +0200, Frank Lichtenheld wrote:
On Sun, May 13, 2007 at 01:04:15PM -0700, Junio C Hamano wrote:
quoted
Frank Lichtenheld [off-list ref] writes:
quoted
Add a few test cases for the config file parsing
done by git-cvsserver.

Signed-off-by: Frank Lichtenheld <redacted>
---
 t/t9420-git-cvsserver-config.sh |  109 +++++++++++++++++++++++++++++++++++++++
 1 files changed, 109 insertions(+), 0 deletions(-)
 create mode 100755 t/t9420-git-cvsserver-config.sh
Do we really need a separate test script that does quite similar setup?
Right now, probably not.

But I certainly don't intend to do all the tests in one big file which
will become rather large over time. If you're concerned with code
duplication, maybe I should move the code to a separate file and source
it from there?
Still waiting on a comment here...

Gruesse,
-- 
Frank Lichtenheld [off-list ref]
www: http://www.djpig.de/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help