Re: [PATCH] Support ent:relative_path

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] Support ent:relative_path

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:08

Johannes Schindelin [off-list ref] writes:
FWIW I still find that unintuitive. I know "<something>:<path>" from ssh, 
and there it does not change meaning depending on where I am. IMHO in most 
cases you want to use git-diff anyway, which _does_ honour the current 
relative path.
There, its meaning is relative to where you are, namely "$HOME".

Re: [PATCH] Support ent:relative_path

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:43:08

Hi,

On Fri, 4 May 2007, Junio C Hamano wrote:
Johannes Schindelin [off-list ref] writes:
quoted
FWIW I still find that unintuitive. I know "<something>:<path>" from ssh, 
and there it does not change meaning depending on where I am. IMHO in most 
cases you want to use git-diff anyway, which _does_ honour the current 
relative path.
There, its meaning is relative to where you are, namely "$HOME".
No, it is relative to where I am _at the other end_. If I "cd /tmp", it 
still is relative to $HOME.

Now, what you want to do is changing the meaning of v1.5.1:Makefile, 
depending if you "cd Documentation/"ed or not.

For me, "v1.5.1:" means something similar to ssh: it is a distant 
revision. It is not a complete filesystem. I think of revisions as 
something more general than a directory, but less general than a 
filesystem. And thus, it makes perfect sense to me that "v1.5.1:Makefile" 
means the main Makefile, no matter where I am in the current repository.

Now, I agree that often you want to compare some file in the current 
directory to the corresponding file in a certain revision. That is why 
git-diff has a different idea, and indeed, a different notation, too.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help