[PATCH] Checklist clarifications: added "Commits", "Patch:" headings

Added email address and message 'Send your patch to...'

Signed-off-by: Jari Aalto <redacted>
---
 Documentation/SubmittingPatches |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 2386f49..238d410 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches

@@ -1,5 +1,7 @@
 Checklist (and a short version for the impatient):
 
+	Commits:
+
 	- make commits of logical units
 	- check for unnecessary whitespace with "git diff --check"
 	  before committing

@@ -12,8 +14,13 @@ Checklist (and a short version for the impatient):
 	  commit message (or just use the option "-s" when
 	  committing) to confirm that you agree to the Developer's
 	  Certificate of Origin
+
+	Patch:
+
+	- send your patch to <git@vger.kernel.org> by using
+	  git-format-patch(1) with option "-M". See also
+	  git-send-email(1).
 	- do not PGP sign your patch
-	- use "git format-patch -M" to create the patch
 	- do not attach your patch, but read in the mail
 	  body, unless you cannot teach your mailer to
 	  leave the formatting of the patch alone.

-- 
1.5.1.2.GIT

Hi,

On Mon, 30 Apr 2007, Jari Aalto wrote:

+	- send your patch to [off-list ref] by using
+	  git-format-patch(1) with option "-M". See also
+	  git-send-email(1).
 	- do not PGP sign your patch
-	- use "git format-patch -M" to create the patch

NACK.

I never use send-email myself. There are even technical issues to my 
excuse: sometimes I cannot send the mails from my machine. So, this should 
not be a _replacement_ for `git format-patch -M && send mail manually`, 
but only an _alternative_.

However, my impression was that many people had problems when first 
sending patches with send-email. There should be _at least_ a word of 
caution, that you should test the operation on something different than 
the Git list first.

Ciao,
Dscho

Johannes Schindelin [off-list ref] writes:

Hi,

On Mon, 30 Apr 2007, Jari Aalto wrote:

quoted

+	- send your patch to [off-list ref] by using
+	  git-format-patch(1) with option "-M". See also
+	  git-send-email(1).
 	- do not PGP sign your patch
-	- use "git format-patch -M" to create the patch

NACK.

I never use send-email myself. There are even technical issues to my 
excuse: sometimes I cannot send the mails from my machine. So, this should 
not be a _replacement_ for `git format-patch -M && send mail manually`, 
but only an _alternative_.

However, my impression was that many people had problems when first 
sending patches with send-email. There should be _at least_ a word of 
caution, that you should test the operation on something different than 
the Git list first.

Is this workding okay?

        - send your patch to [off-list ref] by using
          git-format-patch(1) with option "-M". If you use  
          git-send-email(1), please test it first by sending 
          email to yourself.

Jari

On Mon, 30 Apr 2007, Jari Aalto wrote:

Is this workding okay?

       - send your patch to [off-list ref] by using
         git-format-patch(1) with option "-M". If you use
         git-send-email(1), please test it first by sending
         email to yourself.

I don't want to seem picky, but that wording suggests to me that the -M 
option to format-patch magically sends patches to the list.  Why not just 
have:

 	- use "git format-patch -M" to create the patch
 	- send your patch to [off-list ref]. If you use
 	  git-send-email(1), please test it first by sending
 	  email to yourself.

-- 
Julian

  ---
My mother loved children -- she would have given anything if I had been one.
 		-- Groucho Marx

Hi,

On Mon, 30 Apr 2007, Julian Phillips wrote:

On Mon, 30 Apr 2007, Jari Aalto wrote:

quoted

Is this workding okay?

       - send your patch to [off-list ref] by using
         git-format-patch(1) with option "-M". If you use
         git-send-email(1), please test it first by sending
         email to yourself.

I don't want to seem picky, but that wording suggests to me that the -M
option to format-patch magically sends patches to the list.  Why not just
have:

	- use "git format-patch -M" to create the patch
	- send your patch to [off-list ref]. If you use
	  git-send-email(1), please test it first by sending
	  email to yourself.

Yes, I like that much better!

Thank you,
Dscho

From e65853b7bede747912a51fd77d5cf62fb255b116 Mon Sep 17 00:00:00 2001

From: Jari Aalto <redacted>
Date: Mon, 30 Apr 2007 18:57:25 +0300
Subject: [PATCH] Checklist clarifications: added Commits, Patch: headings

Signed-off-by: Jari Aalto <redacted>
---
 This is version 2 of the orignal patch. Corrected according
 to Julian Phillips's comments.

 Documentation/SubmittingPatches |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 2386f49..6a4da2d 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches

@@ -1,5 +1,7 @@
 Checklist (and a short version for the impatient):
 
+	Commits:
+
 	- make commits of logical units
 	- check for unnecessary whitespace with "git diff --check"
 	  before committing

@@ -12,8 +14,14 @@ Checklist (and a short version for the impatient):
 	  commit message (or just use the option "-s" when
 	  committing) to confirm that you agree to the Developer's
 	  Certificate of Origin
-	- do not PGP sign your patch
+
+	Patch:
+
 	- use "git format-patch -M" to create the patch
+	- send your patch to <git@vger.kernel.org>. If you use
+	  git-send-email(1), please test it first by sending
+	  email to yourself.
+	- do not PGP sign your patch
 	- do not attach your patch, but read in the mail
 	  body, unless you cannot teach your mailer to
 	  leave the formatting of the patch alone.

-- 
1.5.1.2.GIT

Johannes Schindelin [off-list ref] writes:

However, my impression was that many people had problems when first 
sending patches with send-email. There should be _at least_ a word of 
caution, that you should test the operation on something different than 
the Git list first.

Also an EXAMPLES section to Documentation/git-send-email.txt
would be useful.