Re: [PATCH] Ensure test-genrandom availability for t5301/t5302

Subsystems: kernel build + files below scripts/ (unless maintained elsewhere), the rest

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] Ensure test-genrandom availability for t5301/t5302

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:07

Dana How [off-list ref] writes:
quoted hunk
Check for this as well as test-chmtime in test-lib.sh

Signed-off-by: Dana L. How <redacted>
---
 t/test-lib.sh |   13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index f2c6bd3..d7838fc 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -268,11 +268,14 @@ test -d ../templates/blt || {
 	error "You haven't built things yet, have you?"
 }
 
-if ! test -x ../test-chmtime; then
-	echo >&2 'You need to build test-chmtime:'
-	echo >&2 'Run "make test-chmtime" in the source (toplevel) directory'
-	exit 1
-fi
+for prog in test-chmtime test-genrandom
+do
+	if ! test -x ../$prog; then
+		echo >&2 "You need to build $prog:"
+		echo >&2 "Run \"make $prog\" in the source (toplevel) directory"
+		exit 1
+	fi
+done
 
 # Test repository
 test=trash
-- 
1.5.2.rc0.71.g4342-dirty
As these two are very small programs, why not always build them
upon "make all", like this?

---
 Makefile |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 60c41fd..817f8ef 100644
--- a/Makefile
+++ b/Makefile
@@ -933,13 +933,17 @@ endif
 
 ### Testing rules
 
+TEST_PROGRAMS = test-chmtime$X test-genrandom$X
+
+all:: $(TEST_PROGRAMS)
+
 # GNU make supports exporting all variables by "export" without parameters.
 # However, the environment gets quite big, and some programs have problems
 # with that.
 
 export NO_SVN_TESTS
 
-test: all test-chmtime$X test-genrandom$X
+test: all
 	$(MAKE) -C t/ all
 
 test-date$X: test-date.c date.o ctype.o

Re: [PATCH] Ensure test-genrandom availability for t5301/t5302

From: Dana How <hidden>
Date: 2016-06-15 22:43:07

Either way is fine with me.
I just don't want any one to have the nasty surprise I had --
fortunately I figured it out quickly.

So you will apply your patch?

Thanks,

Dana

On 4/28/07, Junio C Hamano [off-list ref] wrote:
quoted hunk
Dana How [off-list ref] writes:
quoted
Check for this as well as test-chmtime in test-lib.sh

Signed-off-by: Dana L. How <redacted>
---
 t/test-lib.sh |   13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index f2c6bd3..d7838fc 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -268,11 +268,14 @@ test -d ../templates/blt || {
      error "You haven't built things yet, have you?"
 }

-if ! test -x ../test-chmtime; then
-     echo >&2 'You need to build test-chmtime:'
-     echo >&2 'Run "make test-chmtime" in the source (toplevel) directory'
-     exit 1
-fi
+for prog in test-chmtime test-genrandom
+do
+     if ! test -x ../$prog; then
+             echo >&2 "You need to build $prog:"
+             echo >&2 "Run \"make $prog\" in the source (toplevel) directory"
+             exit 1
+     fi
+done

 # Test repository
 test=trash
--
1.5.2.rc0.71.g4342-dirty
As these two are very small programs, why not always build them
upon "make all", like this?

---
 Makefile |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 60c41fd..817f8ef 100644
--- a/Makefile
+++ b/Makefile
@@ -933,13 +933,17 @@ endif

 ### Testing rules

+TEST_PROGRAMS = test-chmtime$X test-genrandom$X
+
+all:: $(TEST_PROGRAMS)
+
 # GNU make supports exporting all variables by "export" without parameters.
 # However, the environment gets quite big, and some programs have problems
 # with that.

 export NO_SVN_TESTS

-test: all test-chmtime$X test-genrandom$X
+test: all
        $(MAKE) -C t/ all

 test-date$X: test-date.c date.o ctype.o


-- 
Dana L. How  danahow@gmail.com  +1 650 804 5991 cell
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help