Re: [PATCH] Only use ETC_GITCONFIG=$(prefix)/etc/gitconfig ifeq ($(prefix),$(HOME))

Josh Triplett [off-list ref] writes:

ETC_GITCONFIG defaults to $(prefix)/etc/gitconfig, so if you just set
prefix=/usr or prefix=/usr/local, you end up with a git that looks in
/usr/etc/gitconfig or /usr/local/etc/gitconfig.  That seems rather suboptimal.

Use ifeq in the Makefile to set ETC_GITCONFIG=/etc/gitconfig unless the prefix
points to $HOME .

I personally have four installations of git under $HOME by
setting prefix to $HOME/git-{maint,master,next,pu}.  I would
rather not see this to break, as I suspect there are other
people who depend on this behaviour.

Junio C Hamano [off-list ref] wrote:

Josh Triplett [off-list ref] writes:

quoted

Use ifeq in the Makefile to set ETC_GITCONFIG=/etc/gitconfig unless the prefix
points to $HOME .

I personally have four installations of git under $HOME by
setting prefix to $HOME/git-{maint,master,next,pu}.  I would
rather not see this to break, as I suspect there are other
people who depend on this behaviour.

I second that.  :-)

$ cat config.mak
...
current_branch := \
	$(subst refs/heads/,,$(shell git-symbolic-ref HEAD 2>/dev/null))
ifeq ($(current_branch),)
	prefix := $(HOME)/sw/git-unknownbuild
else
	prefix := $(HOME)/sw/git-$(current_branch)
EOF

;-)

-- 
Shawn.