From: Junio C Hamano <hidden> Date: 2016-06-15 22:43:04
"Michael S. Tsirkin" [off-list ref] writes:
Display the subject of the commit just made.
WHY? You just made the commit.
quoted
Quoting Junio C Hamano [off-list ref]:
Subject: Re: [PATCH] display shortlog after git-commit
Too noisy for a default.
So maybe the following isn't too bad?
This results in:
$ ./git-commit.sh --amend
Created commit 5633ddde0e35210f607bde063bcbf709e4d20a8d
Display the subject of the commit just made.
1 files changed, 1 insertions(+), 1 deletions(-)
I think this is still one line too many. It _might_ be an
improvement if it were
$ ./git-commit.sh --amend
Created commit 5633ddde: Display the subject of the commit just made.
1 files changed, 1 insertions(+), 1 deletions(-)
though...
From: Michael S. Tsirkin <hidden> Date: 2016-06-15 22:43:04
Useful e.g. to figure out what I did from screen history,
or to make sure subject line is short enough and makes sense
on its own.
Signed-off-by: Michael S. Tsirkin <redacted>
---
WHY? You just made the commit.
Hopefully answered above.
This also gets rid of the only user of --no-commit-id, so we
should be able to deprecate this in the future in favor of
--pretty=format:
quoted
quoted
Quoting Junio C Hamano [off-list ref]:
Subject: Re: [PATCH] display shortlog after git-commit
Too noisy for a default.
So maybe the following isn't too bad?
This results in:
$ ./git-commit.sh --amend
Created commit 5633ddde0e35210f607bde063bcbf709e4d20a8d
Display the subject of the commit just made.
1 files changed, 1 insertions(+), 1 deletions(-)
I think this is still one line too many. It _might_ be an
improvement if it were
$ ./git-commit.sh --amend
Created commit 5633ddde: Display the subject of the commit just made.
1 files changed, 1 insertions(+), 1 deletions(-)
though...
Close but no cigar. You broke it for a merge commit, I think.
Perhaps
pretty="format:Created${initial_commit:+ initial} commit %h: %s%n"
git-diff-tree --always --shortstart --summary --root --pretty="$pretty" HEAD
Aha, --always should do the trick. I'll check this.
BTW, a couple of questions:
1. do we really need the shortstat info?
2. why is there "--" at the end do in the original version?
--
MST
From: Michael S. Tsirkin <hidden> Date: 2016-06-15 22:43:04
Display the subject of the commit just made.
Useful e.g. to figure out what I did from screen history,
or to make sure subject line is short enough and makes sense
on its own.
Signed-off-by: Michael S. Tsirkin <redacted>
---
Quoting Junio C Hamano [off-list ref]:
Close but no cigar. You broke it for a merge commit, I think.
Perhaps
pretty="format:Created${initial_commit:+ initial} commit %h: %s%n"
git-diff-tree --always --shortstart --summary --root --pretty="$pretty" HEAD
OK, thanks fo rpointing this out.
But why the extra %n at the end? The following seems to work well for me: