Re: [PATCH] git-clone: Error meaningfully on failed HTTP fetches of HEAD

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] git-clone: Error meaningfully on failed HTTP fetches of HEAD

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:04

Martin Langhoff [off-list ref] writes:
A common problem when cloning over http is that the repo has
a symlink for HEAD, and apache refuses to serve symlinks by
default.

Without this patch, the clone succeeds as a "bare" and "HEADless"
clone, but does not give any indication that things have gone
wrong.

A bare clone that fails to fetch HEAD will still complete
"successfully". I'm not sure if that's expected/desired. Is a
HEADless repo valid in any situation?
You would get "fatal: Not a git repository".  Why not default to
'master' (if found) and issue a warning?

Re: [PATCH] git-clone: Error meaningfully on failed HTTP fetches of HEAD

From: Martin Langhoff <hidden>
Date: 2016-06-15 22:43:04

Junio C Hamano wrote:
quoted
A bare clone that fails to fetch HEAD will still complete
"successfully". I'm not sure if that's expected/desired. Is a
HEADless repo valid in any situation?
You would get "fatal: Not a git repository".  Why not default to
'master' (if found) and issue a warning?
And if not found die() for real...? Ok. I'll rework and resend.

cheers,



m
-- 
-----------------------------------------------------------------------
Martin @ Catalyst .Net .NZ  Ltd, PO Box 11-053, Manners St,  Wellington
WEB: http://catalyst.net.nz/           PHYS: Level 2, 150-154 Willis St
OFFICE: +64(4)916-7224  UK: 0845 868 5733 ext 7224  MOB: +64(21)364-017
      Make things as simple as possible, but no simpler - Einstein
-----------------------------------------------------------------------
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help