Re: [PATCH] Fix passing of TCLTK_PATH to git-gui

3 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] Fix passing of TCLTK_PATH to git-gui

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:03

"Alex Riesen" [off-list ref] writes:
Signed-off-by: Alex Riesen <redacted>
---

GNU make does not include environment variables by default
in its namespace.
Shouldn't this be part of proposed commit log message?

Also I'd appreciate if you did not attach the format-patch
output, but send a properly formatted e-mail.  I would not be so
picky to non-regulars, but I expect I'd be getting many more
patches from you, so...

Re: [PATCH] Fix passing of TCLTK_PATH to git-gui

From: Alex Riesen <hidden>
Date: 2016-06-15 22:43:03

On 4/5/07, Junio C Hamano [off-list ref] wrote:
"Alex Riesen" [off-list ref] writes:
quoted
Signed-off-by: Alex Riesen <redacted>
---

GNU make does not include environment variables by default
in its namespace.
Shouldn't this be part of proposed commit log message?
Err... yes.
Also I'd appreciate if you did not attach the format-patch
output, but send a properly formatted e-mail.  I would not be so
picky to non-regulars, but I expect I'd be getting many more
patches from you, so...
I'll resend as soon as I get home.

[PATCH] Fix passing of TCLTK_PATH to git-gui

From: Alex Riesen <hidden>
Date: 2016-06-15 22:43:03

GNU make does not include environment variables by default
in its namespace. Just pass them in make command line.

Signed-off-by: Alex Riesen <redacted>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index ad321b3..507ad91 100644
--- a/Makefile
+++ b/Makefile
@@ -703,7 +703,7 @@ endif
 
 all::
 ifndef NO_TCLTK
-	$(QUIET_SUBDIR0)git-gui TCLTK_PATH='$(TCLTK_PATH_SQ)' $(QUIET_SUBDIR1) all
+	$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) TCLTK_PATH='$(TCLTK_PATH_SQ)' all
 endif
 	$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all
 	$(QUIET_SUBDIR0)templates $(QUIET_SUBDIR1)
-- 
1.5.1.rc3.48.g803f1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help