Re: git-send-email and aliases

Jeff King [off-list ref] writes:

Might it not be easier to simply add a GIT_NOALIAS variable, and set it
at the top of all git programs?

It might be easier but I do not think that is useful.  When
git-commit runs the $EDITOR for the commit log message, I think
people would expect (if you are using vi) "!!git log" to honor
their alias.

On Tue, Mar 27, 2007 at 03:59:19AM -0700, Junio C Hamano wrote:

It might be easier but I do not think that is useful.  When
git-commit runs the $EDITOR for the commit log message, I think
people would expect (if you are using vi) "!!git log" to honor
their alias.

Then git-commit can unset GIT_NOALIAS when it expects to call into
"user" code such as the editor.

A potentially bigger problem with any such scheme is that non-git
scripts would have to set GIT_NOALIAS. Not a big deal for new scripts,
but it might break old scripts.

-Peff

Jeff King [off-list ref] writes:

On Tue, Mar 27, 2007 at 03:59:19AM -0700, Junio C Hamano wrote:

quoted

It might be easier but I do not think that is useful.  When
git-commit runs the $EDITOR for the commit log message, I think
people would expect (if you are using vi) "!!git log" to honor
their alias.

Then git-commit can unset GIT_NOALIAS when it expects to call into
"user" code such as the editor.

Surely, but then it is not just a matter of "setting GIT_NOALIAS
at the top of all git programs" anymore.  You need to audit the
code.

A potentially bigger problem with any such scheme is that non-git
scripts would have to set GIT_NOALIAS. Not a big deal for new scripts,
but it might break old scripts.

You are right.  Both GIT_NOALIAS and "write git-foo if you do
not want to be affected with alias" would fail that.