DORMANTno replies

[PATCH] cogito: Escape $* in cg admin-setuprepro to fix problems with older bash versions

From: mcdmx <hidden>
Date: 2016-06-15 22:42:59
Subsystem: the rest · Maintainer: Linus Torvalds

Using $* in the _Here_ document at the end of cg-admin-setuprepro seriously confuses Bash
v2.0.5b and causes lines produced by the _Here_ document to look something like

##  EEnnaabbllee ggiitt--uuppddaattee--sseerrvveerr--iinnffoo

The problem does not occur with Bash 3.1.x. The patch below fixes this by escaping the
dollar in "$*".
diff --git a/cg-admin-setuprepo b/cg-admin-setuprepo
index d407798..a37b6ae 100755
--- a/cg-admin-setuprepo
+++ b/cg-admin-setuprepo
@@ -91,7 +91,7 @@ fi
 _git="$uri"
 cat <<_SCRIPT_EOF_ | $shell $shellarg

-die() { echo "$*" >&2; exit 1; }
+die() { echo "\$*" >&2; exit 1; }

 export GIT_DIR="$uri"
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help