Re: [PATCH] Add --pretty=changelog

Johannes Schindelin [off-list ref] writes:

This outputs the log in GNU ChangeLog format.

Many thanks!  I ran this in my cvs->git repository for libtasn1, and
then did a diff against the output from cvs2cl in the old repository.
Here are some categories of differences:

1) Indentation should be under the '*'.  Compare (wrong):

        * src/asn1Coding.c, src/asn1Decoding.c, src/asn1Parser.c: Improve
          --help output.  Assume getopt_long, since gnulib provides it.

with (correct):

        * src/asn1Coding.c, src/asn1Decoding.c, src/asn1Parser.c: Improve
        --help output.  Assume getopt_long, since gnulib provides it.

2) Don't log anything for empty messages:

        * gl/.cvsignore: *** empty log message ***

Possibly, this should be an option.

3) Possible charset problem?  Compare this (correct):

        * configure.in: Fix -Wno-pointer-sign test to respect user-defined
        CFLAGS.  Reported by "Diego 'Flameeyes' Pettenò"
        [off-list ref].

with (wrong):

        * configure.in: Fix -Wno-pointer-sign test to respect user-defined
          CFLAGS.  Reported

The git log do seem to contain the correct data, though, from git-log:

    Fix -Wno-pointer-sign test to respect user-defined CFLAGS.  Reported
    by "Diego 'Flameeyes' Pettenò" [off-list ref].

4) Weird error, compare (correct):

        * lib/coding.c:
        (asn1_der_coding): For TYPE_NULL, increment counter even if we don't
        write any output.  Reported by Stephen Wrobleski
        [off-list ref].

with (wrong):

        * lib/coding.c: (asn1_der_coding): For TYPE_NULL, increment counter
          even if we don't

Maybe this is related to the last one, and the problem really is '<' or '>'?

Here is another one, compare (correct):

        * lib/coding.c:
        (asn1_octet_der): Work even if str_len is 0, i.e., write an ASN.1
        length of zero.  Otherwise encodings became garbled on 64-bit
        platforms, detected while running the Shishi self-tests on the
        Debian build robots.  A self test to reproduce this is in Test_tree.

with (wrong):

        * lib/coding.c: (asn1_octet_der): Work even if str_len is 0, i.e.,
          write an ASN.1

I'll let you fix these and resume the diff later. :)

Can I pull your git tree from somewhere?  Applying patches from e-mail
is kind of boring.

/Simon

Hi,

On Thu, 1 Mar 2007, Simon Josefsson wrote:

Johannes Schindelin [off-list ref] writes:

quoted

This outputs the log in GNU ChangeLog format.

Many thanks!  I ran this in my cvs->git repository for libtasn1, and 
then did a diff against the output from cvs2cl in the old repository. 
Here are some categories of differences:

No good deed goes unpunished, they say...

1) Indentation should be under the '*'.  Compare (wrong):

        * src/asn1Coding.c, src/asn1Decoding.c, src/asn1Parser.c: Improve
          --help output.  Assume getopt_long, since gnulib provides it.

I saw that in your mail already, and I find the style cvs2cl outputs ugly.

2) Don't log anything for empty messages:

        * gl/.cvsignore: *** empty log message ***

Possibly, this should be an option.

It does not log anything for empty messages. Not even a colon.

3) Possible charset problem?  Compare this (correct):

        * configure.in: Fix -Wno-pointer-sign test to respect user-defined
        CFLAGS.  Reported by "Diego 'Flameeyes' Pettenò"
        [off-list ref].

with (wrong):

        * configure.in: Fix -Wno-pointer-sign test to respect user-defined
          CFLAGS.  Reported

The git log do seem to contain the correct data, though, from git-log:

    Fix -Wno-pointer-sign test to respect user-defined CFLAGS.  Reported
    by "Diego 'Flameeyes' Pettenò" [off-list ref].

No charset problem. In Git commit messages, the first line is special. It 
is the so called "oneline" description. If you wrap the oneline, it's your 
fault, not Git's.

4) Weird error, compare (correct):

This is exactly the same as 3).

I'll let you fix these and resume the diff later. :)

As far as I am concerned, I don't think there is anything to fix. Except 
maybe the wrapping of your commit messages, but I guess it is too late now 
to change them?

Can I pull your git tree from somewhere?  Applying patches from e-mail 
is kind of boring.

No, I don't have a public Git tree.

Ciao,
Dscho

Johannes Schindelin [off-list ref] wrote:

No, I don't have a public Git tree.

Shame on you Dscho!  Even Junio has a public git tree!  ;-)

-- 
Shawn.

Hi,

On Thu, 1 Mar 2007, Shawn O. Pearce wrote:

Johannes Schindelin [off-list ref] wrote:

quoted

No, I don't have a public Git tree.

Shame on you Dscho!  Even Junio has a public git tree!  ;-)

What would I do with a public git tree? It would only attract the svn 
dogs, who would cvs piss on it...

Ciao,
Dscho