2 messages, 2 authors, 2016-06-15 · open the first message on its own page
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:56
"Shawn O. Pearce" [off-list ref] writes:
..., and will do the same in GIT-VERSION-GEN for git-gui.
I had an impression that GIT-VERSION-GEN in git-gui was Ok.
What about the top level GIT-VERSION-GEN in git.git?
I thought it is much more careful than git-gui/CREDITS-GEN about avoiding unnecessary rebuilding.
From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:42:56
Junio C Hamano [off-list ref] wrote:
"Shawn O. Pearce" [off-list ref] writes:quoted
..., and will do the same in GIT-VERSION-GEN for git-gui.I had an impression that GIT-VERSION-GEN in git-gui was Ok.
It is. I just looked at it to see about fixing it too and just realized what the `test $VN = $VC ||` chunk was all about. :-)
quoted
What about the top level GIT-VERSION-GEN in git.git?I thought it is much more careful than git-gui/CREDITS-GEN about avoiding unnecessary rebuilding.
Yes, it is. I didn't realize what it was doing until just now. :-) Apparently I'm missing the obvious tonight. There is a new version of git-gui now pushed out (1 commit, your patch). I did not bother to tag it. Please pull into maint. -- Shawn.