[PATCH 2/2] Correct some language in fast-import documentation.

Subsystems: documentation, the rest

DORMANTno replies

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH 2/2] Correct some language in fast-import documentation.

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:42:53

Minor documentation improvements, as suggested on the Git mailing
list by Horst H. von Brand and Karl Hasselström.

Signed-off-by: Shawn O. Pearce <redacted>
---
 Documentation/git-fast-import.txt |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt
index 0c44761..01f4c8a 100644
--- a/Documentation/git-fast-import.txt
+++ b/Documentation/git-fast-import.txt
@@ -181,7 +181,7 @@ If the local offset is not available in the source material, use
 ``+0000'', or the most common local offset.  For example many
 organizations have a CVS repository which has only ever been accessed
 by users who are located in the same location and timezone.  In this
-case the offset from UTC can be easily assumed.
+case a reasonable offset from UTC could be assumed.
 +
 Unlike the `rfc2822` format, this format is very strict.  Any
 variation in formatting will cause gfi to reject the value.
@@ -190,7 +190,7 @@ variation in formatting will cause gfi to reject the value.
 	This is the standard email format as described by RFC 2822.
 +
 An example value is ``Tue Feb 6 11:22:18 2007 -0500''.  The Git
-parser is accurate, but a little on the lenient side.  Its the
+parser is accurate, but a little on the lenient side.  It is the
 same parser used by gitlink:git-am[1] when applying patches
 received from email.
 +
@@ -205,14 +205,15 @@ contained in an RFC 2822 date string is used to adjust the date
 value to UTC prior to storage.  Therefore it is important that
 this information be as accurate as possible.
 +
-If the source material is formatted in RFC 2822 style dates,
+If the source material uses RFC 2822 style dates,
 the frontend should let gfi handle the parsing and conversion
 (rather than attempting to do it itself) as the Git parser has
 been well tested in the wild.
 +
 Frontends should prefer the `raw` format if the source material
-is already in UNIX-epoch format, or is easily convertible to
-that format, as there is no ambiguity in parsing.
+already uses UNIX-epoch format, can be coaxed to give dates in that
+format, or its format is easiliy convertible to it, as there is no
+ambiguity in parsing.
 
 `now`::
 	Always use the current time and timezone.  The literal
-- 
1.5.0.rc3.175.g6506

Re: [PATCH 2/2] Correct some language in fast-import documentation.

From: Uwe Kleine-König <hidden>
Date: 2016-06-15 22:42:53

Hello Shawn,

Shawn O. Pearce wrote:
Minor documentation improvements, as suggested on the Git mailing
list by Horst H. von Brand and Karl Hasselström.
you have an encoding problem here     ---------^

That "o umlaut" seems to be UTF-8 encoded, but the headers of you mail
claim iso-8859-1.

I had this kind of problem, too.  You have to assert that the
environment variable LANG (or LC_CTYPE) match your terminal and the mutt
config variable "charset" matches that, too.  (Not to set charset seems
to do the right thing.)

Best regards
Uwe

-- 
Uwe Kleine-König

http://www.google.com/search?q=1+electron+mass%3D
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help