[PATCH - todo] Changes to e-mailed patch handling in v1.5.0

Subsystems: the rest

DORMANTno replies

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

[PATCH - todo] Changes to e-mailed patch handling in v1.5.0

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:49

This applies to the draft v1.5.0 release notes in 'todo' branch and
summarizes the changes my patches to format-patch bring in.  

I am neutral about changing the default suffix from .txt to .patch;
comments?

diff --git a/v1.5.0.txt b/v1.5.0.txt
index 2fccf8e..6a9a8d6 100644
--- a/v1.5.0.txt
+++ b/v1.5.0.txt
@@ -268,6 +268,21 @@ Updates in v1.5.0 since v1.4.4 series
    excuse us for this very minor one-time inconvenience.
 
 
+* e-mailed patches
+
+ - See the above I18n section.
+
+ - git-format-patch now enables --binary without being asked.
+   git-am does _not_ default to it, as sending binary patch via
+   e-mail is unusual and is harder to review than textual
+   patches and it is prudent to require the person who is
+   applying the patch to explicitly ask for it.
+
+ - The default suffix for git-format-patch output is now ".patch",
+   not ".txt".  This can be changed with --suffix=.txt option,
+   or "format.suffix = .txt" in the configuration.
+
+
 * Foreign SCM interfaces
 
   - git-svn now requires the Perl SVN:: libraries, the

Re: [PATCH - todo] Changes to e-mailed patch handling in v1.5.0

From: Andy Parkins <hidden>
Date: 2016-06-15 22:42:49

On Wednesday 2007 January 17 23:06, Junio C Hamano wrote:
I am neutral about changing the default suffix from .txt to .patch;
comments?
I'm in favour.  The extension indicates file type, and gives guidance on the 
tool that can read it. Though .patch is stored in text it's more than that 
(c.f. .html) - the text inside it has meaning beyond just the text.

To me, .txt would implies that the file format is in human-language format 
(i.e. words, sentences, and paragraphs).


Andy
-- 
Dr Andy Parkins, M Eng (hons), MIEE
andyparkins@gmail.com

Re: [PATCH - todo] Changes to e-mailed patch handling in v1.5.0

From: Brian Gernhardt <hidden>
Date: 2016-06-15 22:42:49

On Jan 18, 2007, at 3:18 AM, Andy Parkins wrote:
On Wednesday 2007 January 17 23:06, Junio C Hamano wrote:
quoted
I am neutral about changing the default suffix from .txt to .patch;
comments?
I'm in favour.  The extension indicates file type, and gives  
guidance on the
tool that can read it. Though .patch is stored in text it's more  
than that
(c.f. .html) - the text inside it has meaning beyond just the text.

To me, .txt would implies that the file format is in human-language  
format
(i.e. words, sentences, and paragraphs).
Ditto.

Also, Vim nicely detects the From <SHA1> line at the top and thinks  
that it's an mbox file.  With the patch extension it ignores that and  
gives me my diff coloring again.

~~ Brian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help