Re: [PATCH 2/2] gitweb: Show trailing slash when listing tree entry in tree listing

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 2/2] gitweb: Show trailing slash when listing tree entry in tree listing

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:43

Luben Tuikov [off-list ref] writes:
quoted hunk
--- Petr Baudis <pasky@suse.cz> wrote:
quoted
Signed-off-by: Petr Baudis <redacted>
---
First, this is a Unixism, and would confuse other OS users.
Second, "/" is after all _not part of the name_ of the tree/directory,
but part of the filesystem's path separator, let's not export it
to users of other OS's.
Third, directories/trees are already clearly 
  1) underlined, and
  2) differently colored,
which makes it overly obvious what it what.
I was actually hoping that we can get rid of the differences you
cited above.

Underlines make entries harder to read, and colouring is 
distracting; some people do not see all colours and to them it
may not distracting but then they need another way to notice the
differences between tree/blob.

Re: [PATCH 2/2] gitweb: Show trailing slash when listing tree entry in tree listing

From: Luben Tuikov <hidden>
Date: 2016-06-15 22:42:43

--- Junio C Hamano <junkio@cox.net> wrote:
Luben Tuikov [off-list ref] writes:
quoted
--- Petr Baudis <pasky@suse.cz> wrote:
quoted
Signed-off-by: Petr Baudis <redacted>
---
First, this is a Unixism, and would confuse other OS users.
Second, "/" is after all _not part of the name_ of the tree/directory,
but part of the filesystem's path separator, let's not export it
to users of other OS's.
Third, directories/trees are already clearly 
  1) underlined, and
  2) differently colored,
which makes it overly obvious what it what.
I was actually hoping that we can get rid of the differences you
cited above.

Underlines make entries harder to read, and colouring is 
distracting; some people do not see all colours and to them it
may not distracting but then they need another way to notice the
differences between tree/blob.
I know, I've seen your email on that and have your patch with the
icons applied at work.  But it is black and white and I'd rather
see some nice color and shading if we're going to change that.

I don't mind using nice warm color icons in the left-most column.

   Luben
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help