cg-commit -p -m ignores -p

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

cg-commit -p -m ignores -p

From: Gerrit Pape <hidden>
Date: 2016-06-15 22:42:40

Hi, please see http:/bugs.debian.org/387515 or below.  I agree that
ideally cg-commit should behave differently.

Thanks, Gerrit.

----- Forwarded message from Andrew Suffield [off-list ref] -----

cg-commit -p -m ignores the -p argument and silently commits. Yes,
this is documented, but it's still stupid behaviour; if the user had
meant that, they would have just used -m alone.

At the very least, it should abort with an error (on the basis that
the command makes no sense); more sensibly, it should create a log
message with the given string and then spawn an editor (and then since
the user will probably exit without changing the file, the "Abort or
commit?" message would appear as per usual, which seems to me to be
appropriate behaviour).


----- End forwarded message -----

Re: cg-commit -p -m ignores -p

From: Petr Baudis <hidden>
Date: 2016-06-15 22:42:41

Dear diary, on Fri, Sep 15, 2006 at 03:23:19PM CEST, I got a letter
where Gerrit Pape [off-list ref] said that...
Hi, please see http:/bugs.debian.org/387515 or below.  I agree that
ideally cg-commit should behave differently.

Thanks, Gerrit.

----- Forwarded message from Andrew Suffield [off-list ref] -----

cg-commit -p -m ignores the -p argument and silently commits. Yes,
this is documented, but it's still stupid behaviour; if the user had
meant that, they would have just used -m alone.

At the very least, it should abort with an error (on the basis that
the command makes no sense); more sensibly, it should create a log
message with the given string and then spawn an editor (and then since
the user will probably exit without changing the file, the "Abort or
commit?" message would appear as per usual, which seems to me to be
appropriate behaviour).


----- End forwarded message -----
Thanks, fixed by making cg-commit -p imply -e.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help