Jakub Narebski [off-list ref] writes:
Junio C Hamano wrote:
quoted
Using tag has an added benefit that you now have a place to say
why you dropped it. So what we would need to support this is an
agreed-upon name under $GIT_DIR/refs/ that is omitted from
display by convention across Porcelains (the core side should
not ignore them because even when you are abandoning them, you
do not want to lose them),
I think that using hidden directory (dot-directory), e.g.
$GIT_DIR/refs/.abandoned/ is a good idea... unless it conflicts somewhat
with the way lock files are named...
Names are not interesting. Visualizers ignoring them
consistently is.
By the way, does gitweb still walk $GIT_DIR/refs hierarchy by
hand to find out the set of refs? When Linus is done with his
refs/ work, that way would become unsupported. You would need
to read from "ls-remote $GIT_DIR".
Junio C Hamano wrote:
By the way, does gitweb still walk $GIT_DIR/refs hierarchy by
hand to find out the set of refs? When Linus is done with his
refs/ work, that way would become unsupported. You would need
to read from "ls-remote $GIT_DIR".
Still, unfortunately. We could change git_get_references to use
'git ls-remotes $GIT_DIR' (or 'git --git-dir=$GIT_DIR ls-remotes .'),
and use git_get_references("refs/heads") in git_heads (and git_summary),
and git_get_references("refs/tags") in git_tags. This _could_ be slower
than current implementation. git-show-refs would help a bit, but I'd rather
have git-show-refs in released version of git before using it in gitweb.
Moreover, git currently reads appropriate ref directly in
git_get_hash_by_ref, not supporting even symrefs, not to mention packed
refs. One solution would be to add support for symrefs and packed refs
directly in gitweb (Git.pm can help here), another to use git core command
(git-rev-parse?) but that can make gitweb slower (additional fork).
I hope that Linus work will be left to mature first in 'pu', then in 'next'
branch... wouldn't refs cache (similar to current index for files) be
better idea?
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Dear diary, on Wed, Sep 13, 2006 at 09:34:24PM CEST, I got a letter
where Jakub Narebski [off-list ref] said that...
I hope that Linus work will be left to mature first in 'pu', then in 'next'
branch...
Yes, me too - I still need to fix Cogito. :-)
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Snow falling on Perl. White noise covering line noise.
Hides all the bugs too. -- J. Putnam