Re: [PATCH 1/2] archive: allow remote to have more formats than we understand.

"Franck Bui-Huu" [off-list ref] writes:

quoted

+static const char *remote_request(int *ac, const char **av)
+{

just to be consistent with the rest of the file, I would have called
this function
"parse_remote_arg" or "extract_remote_arg"

I was thinking about calling this is_remote_request() actually.

2006/9/10, Junio C Hamano [off-list ref]:

"Franck Bui-Huu" [off-list ref] writes:

quoted

quoted

+static const char *remote_request(int *ac, const char **av)
+{

just to be consistent with the rest of the file, I would have called
this function
"parse_remote_arg" or "extract_remote_arg"

I was thinking about calling this is_remote_request() actually.

that sounds like to return a boolean. You would need to pass remote as
a parameter, no ?
I think extract_remote_arg is nice because it tells you that it
returns remote option valu _and_ remove it from argv.

-- 
               Franck