Re: [PATCH 0/2] gitweb: Get rid of failed experiments ;-)

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 0/2] gitweb: Get rid of failed experiments ;-)

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:38

Jakub Narebski [off-list ref] writes:
Remove unused subroutines or subroutines which don't work correctly from 
gitweb.
I'll apply both, thanks.  [2/2] had a fuzz at the very end of
the second hunk (your base version do not have -M to diff-tree
parameter anymore) but that was easy to deal with.

Also thanks for the reminder about "typo in git_patchset_body".

[PATCH] gitweb: Remove forgotten call to git_to_hash

From: Dennis Stosberg <hidden>
Date: 2016-06-15 22:42:38

On Aug 27th, Jakub Narebski sent a patch which removed the git_to_hash()
function and this call to it. The patch did not apply cleanly and had to
be applied manually. Removing the last chunk has obviously been forgotten.

See: commit  0aea33762b1262d11fb43eda9f3fc152b5622cca and
     message [off-list ref]

Signed-off-by: Dennis Stosberg <redacted>
---
 gitweb/gitweb.perl |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 9324d71..68f40bd 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2778,10 +2778,6 @@ sub git_blobdiff {
 			@difftree
 				or die_error('404 Not Found', "Blob diff not found");
 
-		} elsif (defined $hash) { # try to find filename from $hash
-			if ($hash !~ /[0-9a-fA-F]{40}/) {
-				$hash = git_to_hash($hash);
-			}
 		} elsif (defined $hash &&
 		         $hash =~ /[0-9a-fA-F]{40}/) {
 			# try to find filename from $hash
-- 
1.4.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help