Re: [PATCH 16/19] gitweb: Use git-diff-tree or git-diff patch output for blobdiff

Jakub Narebski [off-list ref] writes:

Jakub Narebski wrote:

quoted

ATTENTION: The order of arguments (operands) to git-diff is reversed
(sic!) to have correct diff in the legacy (no hash_parent_base) case.
$hash_parent, $hash ordering is commented out, as it gives reversed
patch (at least for git version 1.4.1.1) as compared to output in new
scheme and output of older gitweb version.

By the way, wa it corrected later? git version 1.4.1.1

I think you were involved in the thread that resulted in the 
fix...

53dd8a9 Show both blob names from "git diff blob1 blob2"
f82cd3c Fix "git diff blob1 blob2" showing the diff in reverse.

Junio C Hamano wrote:

Jakub Narebski [off-list ref] writes:

quoted

Jakub Narebski wrote:

quoted

ATTENTION: The order of arguments (operands) to git-diff is reversed
(sic!) to have correct diff in the legacy (no hash_parent_base) case.
$hash_parent, $hash ordering is commented out, as it gives reversed
patch (at least for git version 1.4.1.1) as compared to output in new
scheme and output of older gitweb version.

By the way, wa it corrected later? git version 1.4.1.1

I think you were involved in the thread that resulted in the 
fix...

53dd8a9 Show both blob names from "git diff blob1 blob2"
f82cd3c Fix "git diff blob1 blob2" showing the diff in reverse.

Gaah. So I'd have to fix the gitweb, i.e. remove workaround
(and update git to 1.4.2). 

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git