Re: [PATCH 3] gitweb: Show information about incomplete lines in commitdiff

Jakub Narebski [off-list ref] writes:

In format_diff_line, instead of skipping errors/incomplete lines,
for example
  "\ No newline at end of file"
in HTML pretty-printing of diff, use "incomplete" class for div.

Signed-off-by: Jakub Narebski <redacted>

I think this makes sense, while I do not see much point in
removal of git_commitdiff_plain.

Junio C Hamano wrote:

I do not see much point in
removal of git_commitdiff_plain.

So should I split git_commitdiff into two subroutines,
or should I left it as it is after
  gitweb: Use git-diff-tree patch output for commitdiff
i.e. git_commitdiff('plain') for git_commitdiff_plain?

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git