DORMANTno replies

[PATCH 06/28] make cmd_log_walk void

From: David Rientjes <rientjes@google.com>
Date: 2016-06-15 22:42:37
Subsystem: the rest · Maintainer: Linus Torvalds

Makes cmd_log_walk void.

		David

Signed-off-by: David Rientjes <rientjes@google.com>
---
 builtin-log.c |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/builtin-log.c b/builtin-log.c
index 691cf3a..cf103ea 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -29,7 +29,7 @@ static void cmd_log_init(int argc, const
 		die("unrecognized argument: %s", argv[1]);
 }
 
-static int cmd_log_walk(struct rev_info *rev)
+static void cmd_log_walk(struct rev_info *rev)
 {
 	struct commit *commit;
 
@@ -41,7 +41,6 @@ static int cmd_log_walk(struct rev_info 
 		free_commit_list(commit->parents);
 		commit->parents = NULL;
 	}
-	return 0;
 }
 
 int cmd_whatchanged(int argc, const char **argv, const char *prefix)
@@ -56,7 +55,8 @@ int cmd_whatchanged(int argc, const char
 	cmd_log_init(argc, argv, prefix, &rev);
 	if (!rev.diffopt.output_format)
 		rev.diffopt.output_format = DIFF_FORMAT_RAW;
-	return cmd_log_walk(&rev);
+	cmd_log_walk(&rev);
+	return 0;
 }
 
 int cmd_show(int argc, const char **argv, const char *prefix)
@@ -73,7 +73,8 @@ int cmd_show(int argc, const char **argv
 	rev.ignore_merges = 0;
 	rev.no_walk = 1;
 	cmd_log_init(argc, argv, prefix, &rev);
-	return cmd_log_walk(&rev);
+	cmd_log_walk(&rev);
+	return 0;
 }
 
 int cmd_log(int argc, const char **argv, const char *prefix)
@@ -84,7 +85,8 @@ int cmd_log(int argc, const char **argv,
 	init_revisions(&rev, prefix);
 	rev.always_show_header = 1;
 	cmd_log_init(argc, argv, prefix, &rev);
-	return cmd_log_walk(&rev);
+	cmd_log_walk(&rev);
+	return 0;
 }
 
 static int istitlechar(char c)
-- 
1.4.2.g89bb-dirty
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help