Re: [PATCH] Racy git: avoid having to be always too careful

Johannes Schindelin [off-list ref] writes:

This makes "make test" dog slow. How about making this overrideable?
(It is just a guess, but I _think_ that the sleeping is worse than having 
to check the files with the same time stamp again and again -- a "git 
status" will help that).


-- 8< --
[PATCH] read-cache: optionally disable being cautious with racy caches

By setting the environment variable GIT_RISK_RACY_CACHE or the config
variable core.riskRacyCache, the sleeping (to avoid a racy cache) is
disabled.

"RISK" is a misnomer here -- the original code without patch is
being cautious and taking a runtime hit but not risky.  The
"delay while writing the cache out for the first time" is trying
to avoid the runtime hit by taking a hit at cache generation
time.  In either case you never risk racy cache.

Perhaps throwing away the whole "delay" thing might be simpler
and more worthwhile.

Another possibility is to tweak the heuristics -- currently we
say 20 paths or 1/4 of whole paths is too many and would cause
too much runtime hit but that was done without any measurement.
We could raise the threashold which would solve the case for the
testsuite whose trees are all small.

Hi,

On Tue, 8 Aug 2006, Junio C Hamano wrote:

Another possibility is to tweak the heuristics -- currently we
say 20 paths or 1/4 of whole paths is too many and would cause
too much runtime hit but that was done without any measurement.
We could raise the threashold which would solve the case for the
testsuite whose trees are all small.

Okay, how about 100 paths? And make _this_ a config variable?

Ciao,
Dscho