Re: [PATCH 2/4] gitweb: bugfix: git_commit and git_commitdiff parents

Luben Tuikov [off-list ref] writes:

In git_commit() the hash base of $from_id is $parent, not
$hash:
 - If status is "D", then action blob for $from_id wants
   $parent, not $hash.  History needs $parent too.
 - If status is "R", then action blob for $from_id wants
   $parent, not $hash.

In git_commitdiff() the hash base of $from_id is
$hash_parent, not $hash:
 - If status is "D".
 - If status is "M".

... stopped in mid sentence???

--- Junio C Hamano <junkio@cox.net> wrote:

Luben Tuikov [off-list ref] writes:

quoted

In git_commit() the hash base of $from_id is $parent, not
$hash:
 - If status is "D", then action blob for $from_id wants
   $parent, not $hash.  History needs $parent too.
 - If status is "R", then action blob for $from_id wants
   $parent, not $hash.

In git_commitdiff() the hash base of $from_id is
$hash_parent, not $hash:
 - If status is "D".
 - If status is "M".

... stopped in mid sentence???

Sorry.  The meaning is the same as for git_commit() and as
the paragraph text ("In git_commitdiff() the hash base of ...").

   Luben