Re: [PATCH 1/4] gitweb: blame table row no highlight fix
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:35
Luben Tuikov [off-list ref] writes:
quoted hunk
Until now blame just used the commit/tree/tags/etc style of highlight-able table rows, which have strictly alternating light/dark rows. This is very annoying in blame, since the text is static and it interferes with the per-revision block highlight. Signed-off-by: Luben Tuikov <redacted> --- gitweb/gitweb.css | 4 ++++ gitweb/gitweb.perl | 2 +- 2 files changed, 5 insertions(+), 1 deletions(-)diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css index 460e728..47c1ade 100644 --- a/gitweb/gitweb.css +++ b/gitweb/gitweb.css@@ -171,6 +171,10 @@ tr.dark { background-color: #f6f6f0; } +tr.dark2 { + background-color: #f6f6f0; +} + tr.dark:hover { background-color: #edece6; }diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 58eb5b1..049f27e 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl@@ -1493,7 +1493,7 @@ sub git_blame2 { git_page_nav('','', $hash_base,$co{'tree'},$hash_base, $formats_nav); git_header_div('commit', esc_html($co{'title'}), $hash_base); git_print_page_path($file_name, $ftype); - my @rev_color = (qw(light dark)); + my @rev_color = (qw(light2 dark2)); my $num_colors = scalar(@rev_color); my $current_color = 0; my $last_rev;
I do not see "tr.light" but "tr.light:hover" in the original CSS. That is kind of understandable (unhovered light ones just use default), but this patch completely lost me. You use light2 class but nothing affects that class in the CSS. Maybe it is the commit log message that is misleading? I guess what you are trying to achieve is to disable the color change that follows the pointer?