[PATCH] Fix http-fetch
From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:42:34
Subsystem:
the rest · Maintainer:
Linus Torvalds
With the latest changes in fetch.c, http-fetch crashed accessing write_ref[i], where write_ref was NULL. Signed-off-by: Johannes Schindelin <redacted> --- fetch.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fetch.c b/fetch.c
index 2151c7b..aeb6bf2 100644
--- a/fetch.c
+++ b/fetch.c@@ -245,7 +245,7 @@ void pull_targets_free(int targets, char { while (targets--) { free(target[targets]); - if (write_ref[targets]) + if (write_ref && write_ref[targets]) free((char *) write_ref[targets]); } }
@@ -263,7 +263,7 @@ int pull(int targets, char **target, con track_object_refs = 0; for (i = 0; i < targets; i++) { - if (!write_ref[i]) + if (!write_ref || !write_ref[i]) continue; lock[i] = lock_ref_sha1(write_ref[i], NULL, 0);
@@ -295,7 +295,7 @@ int pull(int targets, char **target, con msg = NULL; } for (i = 0; i < targets; i++) { - if (!write_ref[i]) + if (!write_ref || !write_ref[i]) continue; ret = write_ref_sha1(lock[i], &sha1[20 * i], msg ? msg : "fetch (unknown)"); lock[i] = NULL;
--
1.4.2.rc2.g0d86-dirty