Re: [PATCH] format-patch: Generate a newline between the subject header and the message body.

Junio C Hamano [off-list ref] writes:

Robert Shearman [off-list ref] writes:

quoted

This patch inserts a newline in two places - once in the loop to
separate the subject part of the commit message from the body part of
the commit message and another after the loop to counteract the eating
of whitespace at the end of the message.

Thanks.

 * Please sign your patch.

 * This breaks a handful t4013 tests, but all in a good way (in
   other words, the expected output files were wrong).

I'll fix up the t/t4013/diff.* files myself.

Actually, I take that back.  This breaks normal commit log
messages by adding extra blank lines.  The extra LF is needed
when the commit log does not have any message (just title).

I'll be tweaking a few tests in t4013 to catch future breakage
of this kind.

Junio C Hamano wrote:

Junio C Hamano [off-list ref] writes:

 

quoted

Robert Shearman [off-list ref] writes:

   

quoted

This patch inserts a newline in two places - once in the loop to
separate the subject part of the commit message from the body part of
the commit message and another after the loop to counteract the eating
of whitespace at the end of the message.
     

Thanks.

* Please sign your patch.

* This breaks a handful t4013 tests, but all in a good way (in
  other words, the expected output files were wrong).

I'll fix up the t/t4013/diff.* files myself.
   

Actually, I take that back.  This breaks normal commit log
messages by adding extra blank lines.  The extra LF is needed
when the commit log does not have any message (just title).
 

Ok, I'll resend with that fixed.

I'll be tweaking a few tests in t4013 to catch future breakage
of this kind.

Thanks.

-- 
Rob Shearman