format-patch previously didn't generate a newline after a subject. This
caused the diffstat to not be displayed in messages without a blank line
and the first blank line to be eaten in messages with a blank line.
This patch inserts a newline in two places - once in the loop to
separate the subject part of the commit message from the body part of
the commit message and another after the loop to counteract the eating
of whitespace at the end of the message.
---
commit.c | 14 ++++++++++++--
1 files changed, 12 insertions(+), 2 deletions(-)
Robert Shearman wrote:
format-patch previously didn't generate a newline after a subject. This
caused the diffstat to not be displayed in messages without a blank line
and the first blank line to be eaten in messages with a blank line.
Does this _enforce_ separating commit message into subject+empty
line+description? What about commit messages without this structire (e.g.
legacy commit messages from import from other SCM, e.g. GNU ChangeLog
style)?
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Jakub Narebski wrote:
Robert Shearman wrote:
quoted
format-patch previously didn't generate a newline after a subject. This
caused the diffstat to not be displayed in messages without a blank line
and the first blank line to be eaten in messages with a blank line.
Does this _enforce_ separating commit message into subject+empty
line+description? What about commit messages without this structire (e.g.
legacy commit messages from import from other SCM, e.g. GNU ChangeLog
style)?
It only affects commits exported into email style. It has nothing to do
with the structure of GIT commit messages or those of any other SCM.
--
Rob Shearman