Re: remove perl from git-commit.sh

"Alex Riesen" [off-list ref] writes:

It is really annoying when the essentials do not work.
I think we could improve at  least them, by minimizing
their dependencies to external tools.

---

git-commit.sh has only ohne place where perl is used
and it can actually quite trivially be done in sh.
git-ls-files without "-z" produces quoted output, even if
is different from that produced by perl code it could be
enough. Otherwise I'd better suggest to add another
quoting style (replacing only \t, \n and backslash) than
having to constantly patch git-commit.sh for binmode
or perl path (Windows has no stable tool set, and perl
for instance often resides "somewhere").

(1) Sign-off?

(2) I think the cover letter comment talks more apporpirate
    things than your proposed commit message.  The commit log is
    not a place to vent your frustration.  It's where you
    justify why that change was needed for people who will want
    to figure out why your patch broke their workflow later.

I do not think anybody parses git-status output to figure out
the list of paths that are touched/untracked/etc., so I am not
opposed to this change itself.

git-commit.sh has the only one place where perl is used
and there it can quite trivially be done in sh.

git-ls-files without "-z" produces quoted output, even if
is different from that produced by perl code it could be
enough. Otherwise I'd better suggest to add another
quoting style (replacing only \t, \n and backslash).

This system is an ugly combination of cygwin and
activestate perl. The combination has some quirks
(like the perl producing \r\n by default, expecting
windows pathnames instead of cygwin fakes, or
ignoring environment variables under some hard to
reproduce circumstances), so reducing number of
this interactions reduces number of hacks one has
to put in core code to make things work. I used to
patch git-commit.sh to put binmode in perl output,
and git-clone.sh still has these calls to cygpath.

Signed-off-by: Alex Riesen <redacted>

---

It is really annoying when the essentials do not work.
I think we could improve at  least them, by minimizing
their dependencies to external tools.

Junio C Hamano wrote:

(1) Sign-off?

done

(2) I think the cover letter comment talks more apporpirate
   things than your proposed commit message.  The commit log is
   not a place to vent your frustration.  It's where you
   justify why that change was needed for people who will want
   to figure out why your patch broke their workflow later.

done.