Re: [PATCH 0/5] Rework diff options

Johannes Schindelin [off-list ref] writes:

Hi,

On Sat, 24 Jun 2006, Timo Hirvonen wrote:

quoted

This patch series cleans up diff output format options.

Very good.

Although I understand that to convert all users to the new convention, it 
is sensible to rename the constants, I think it is not good to change 
something as DIFF_FORMAT_RAW to OUTPUT_FMT_RAW in the resulting patch.

I personally feel that the benefit of being able to make sure
you covered everything outweighs the size of initial diff.

Thanks Timo.  Will take a look.

Hi,

On Fri, 23 Jun 2006, Junio C Hamano wrote:

I personally feel that the benefit of being able to make sure you 
covered everything outweighs the size of initial diff.

IMHO the difficulty of finding bugs is proportional to the square of the 
diff size, while the number of people willing to review it is proportional 
to its square root. So, if it is not difficult (which it is not at all in 
this case), I politely ask to cut the patch size down.

Ciao,
Dscho