DORMANTno replies

[PATCH] Git.pm: Implement Git::version()

From: Petr Baudis <hidden>
Date: 2016-06-15 22:42:30
Subsystem: kernel build + files below scripts/ (unless maintained elsewhere), the rest · Maintainers: Nathan Chancellor, Nicolas Schier, Linus Torvalds

Git::version() returns the Git version string.

Signed-off-by: Petr Baudis <redacted>
---

 Makefile    |    5 ++++-
 perl/Git.pm |   12 ++++++++++++
 perl/Git.xs |    8 ++++++++
 3 files changed, 24 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 4d20b22..7842195 100644
--- a/Makefile
+++ b/Makefile
@@ -596,7 +596,10 @@ XDIFF_OBJS=xdiff/xdiffi.o xdiff/xprepare
 
 
 perl/Makefile:	perl/Git.pm perl/Makefile.PL
-	(cd perl && $(PERL_PATH) Makefile.PL PREFIX="$(prefix)" DEFINE="$(ALL_CFLAGS)" LIBS="$(LIBS)")
+	(cd perl && $(PERL_PATH) Makefile.PL \
+		PREFIX="$(prefix)" \
+		DEFINE="$(ALL_CFLAGS) -DGIT_VERSION=\\\"$(GIT_VERSION)\\\"" \
+		LIBS="$(LIBS)")
 
 doc:
 	$(MAKE) -C Documentation all
diff --git a/perl/Git.pm b/perl/Git.pm
index 5b233ed..3f85000 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -285,6 +285,18 @@ sub command_noisy {
 }
 
 
+=item version ()
+
+Return the Git version in use.
+
+Implementation of this function is very fast; no external command calls
+are involved.
+
+=cut
+
+# Implemented in Git.xs.
+
+
 =item exec_path ()
 
 Return path to the git sub-command executables (the same as
diff --git a/perl/Git.xs b/perl/Git.xs
index 792dc6d..4d57685 100644
--- a/perl/Git.xs
+++ b/perl/Git.xs
@@ -22,6 +22,14 @@ # /* TODO: xs_call_gate(). See Git.pm. *
 
 
 const char *
+xs_version()
+CODE:
+	RETVAL = GIT_VERSION;
+OUTPUT:
+	RETVAL
+
+
+const char *
 xs_exec_path()
 CODE:
 	RETVAL = git_exec_path();
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help