Re: [PATCH] Pass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used.

3 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] Pass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:30

Petr Baudis [off-list ref] writes:
Dear diary, on Thu, Jun 22, 2006 at 09:19:52AM CEST, I got a letter
where Junio C Hamano [off-list ref] said that...
quoted
For that matter, I do not think tracking prefix_SQ makes much
sense since what matters are bindir, gitexecdir and template_dir
which are already covered, and prefix is merely a convenience to
set these three (four, counting GIT_PYTHON_DIR; we probably
should add it to TRACK_CFLAGS).
$(prefix) will be passed to perl/Makefile.PL.
Then probably it shouldn't; instead we woulld probably want to
pass the moral equivalent of GIT_PYTHON_DIR.

Re: [PATCH] Pass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used.

From: Petr Baudis <hidden>
Date: 2016-06-15 22:42:30

Dear diary, on Thu, Jun 22, 2006 at 07:11:49PM CEST, I got a letter
where Junio C Hamano [off-list ref] said that...
Petr Baudis [off-list ref] writes:
quoted
Dear diary, on Thu, Jun 22, 2006 at 09:19:52AM CEST, I got a letter
where Junio C Hamano [off-list ref] said that...
quoted
For that matter, I do not think tracking prefix_SQ makes much
sense since what matters are bindir, gitexecdir and template_dir
which are already covered, and prefix is merely a convenience to
set these three (four, counting GIT_PYTHON_DIR; we probably
should add it to TRACK_CFLAGS).
$(prefix) will be passed to perl/Makefile.PL.
Then probably it shouldn't; instead we woulld probably want to
pass the moral equivalent of GIT_PYTHON_DIR.
I'm not sure about what the rationale behind GIT_PYTHON_DIR was, but it
seems to be used only by a library supposedly internal to some Git
commands, while the Git.pm module should be available systemwide even
for non-Git applications, so it's really best to leave it to Perl where
to put it.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
A person is just about as big as the things that make them angry.

Re: [PATCH] Pass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:30

Petr Baudis [off-list ref] writes:
... while the Git.pm module should be available systemwide even
for non-Git applications, so it's really best to leave it to Perl where
to put it.
OK, if that is the intention passing prefix might be sensible.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help