Re: [PATCH] gitk: Replace "git-" commands with "git "

"Alex Riesen" [off-list ref] wrote:

On 5/24/06, Timo Hirvonen [off-list ref] wrote:

quoted

git-* commands work only if gitexecdir is in PATH.

How about getting exec-path (git --exec-path) and prepend it
to every git-<call> instead? You'll save a fork+exec a call in this case.

Many commands are already built-in so I don't think it's a problem
anymore.

-- 
http://onion.dynserv.net/~timo/

Timo Hirvonen writes:

Many commands are already built-in so I don't think it's a problem
anymore.

Which ones are built in now?

Paul.

Paul Mackerras [off-list ref] wrote:

Timo Hirvonen writes:

quoted

Many commands are already built-in so I don't think it's a problem
anymore.

Which ones are built in now?

git-log$X git-whatchanged$X git-show$X \
git-count-objects$X git-diff$X git-push$X \
git-grep$X git-add$X git-rm$X git-rev-list$X \
git-check-ref-format$X \
git-init-db$X git-tar-tree$X git-upload-tar$X git-format-patch$X \
git-ls-files$X git-ls-tree$X \
git-read-tree$X git-commit-tree$X \
git-apply$X git-show-branch$X git-diff-files$X \
git-diff-index$X git-diff-stages$X git-diff-tree$X git-cat-file$X

-- 
http://onion.dynserv.net/~timo/

OK, thanks.  I have applied your patch.  The ones that gitk uses that
aren't built-in now are git-rev-parse and git-repo-config, which
aren't performance-critical.

Paul.