Re: [PATCH] Make die() and error() prefix line with binary name if set

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] Make die() and error() prefix line with binary name if set

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:24

Rocco Rutte [off-list ref] writes:

Now, git_set_appname() can be used to set the name of the binary
as first call in a binary's main() routine which will be used
as prefix in die() and error(). If it was not called, no prefix
will be printed.

I agree with the general direction, but...

quoted hunk

@@ -1960,6 +1960,8 @@ int main(int argc, char **argv)
 	int read_stdin = 1;
 	const char *whitespace_option = NULL;
 +	git_set_appname("git-apply");
+
 	for (i = 1; i < argc; i++) {
 		const char *arg = argv[i];
 		char *end;

... what's wrong with your mailer?

Re: [PATCH] Make die() and error() prefix line with binary name if set

From: Rocco Rutte <hidden>
Date: 2016-06-15 22:42:24

* Junio C Hamano [off-list ref]:

... what's wrong with your mailer?

I don't know. I recall to have seen this earlier.

And while I'll look at it (I bet this an f=f issue), the patch is at:

   <http://user.cs.tu-berlin.de/~pdmef/0001-Make-die-and-error-prefix-line-with-binary-name-if-set.txt>

   bye, Rocco
-- 
:wq!

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help