Re: [PATCH] Provide configurable UI font for gitk
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:22
Keith Packard [off-list ref] writes:
This makes the font used in the UI elements of gitk configurable in the same way the other fonts are. The default fonts used in the Xft build of tk8.5 are particularily horrific, making this change more important there. Signed-off-by: Keith Packard <redacted>
Thanks for the patch. I haven't run it, but a quick eyeballing suggests what you did is sane. However,..
proc makewindow {rargs} {
- global canv canv2 canv3 linespc charspc ctext cflist textfont
+ global canv canv2 canv3 linespc charspc ctext cflist textfont
mainfont uifontYour MUA seems to be line-wrapping the patch here and there...
quoted hunk
@@ -345,16 +345,20 @@ proc makewindow {rargs} { menu .bar .bar add cascade -label "File" -menu .bar.file + .bar configure -font $uifont menu .bar.file .bar.file add command -label "Update" -command [list updatecommits$rargs] .bar.file add command -label "Reread references" -command rereadrefs ...
so the patch does not apply X-<. Also, I prefer changes to gitk to be fed via Paul Mackerras tree. If you send changes to gitk to me, I will forward patches with my Acked-by: to him and wait for him to bounce the change back to me through his tree, so it is not a big deal for me, and the changes will _not_ be lost anyway, but I'd still appreciate gitk patches to be sent to Paul first if possible.