annotate.perl triggers rpm bug

From: sean <hidden>
Date: 2016-06-15 22:42:21
Subsystem: the rest · Maintainer: Linus Torvalds

Hi Ryan

Commit 87475f4 exposes a problem in the creation of rpms (at least
on Fedora boxes).   RPM automatically creates a dependency for any
perl "use" lines, and the above commit fools it into creating a false 
dependecy for the nonexistent perl package "revs" because of this
portion of the diff:

+       -S, --rev-file revs-file
+                       use revs from revs-file instead of calling git-rev-list
                        ^^ fools rpm

Obviously this creates a problem when someone goes to install the git-core
rpm.  Any chance we could get a small change to work around this bug in rpm?

Thanks,
Sean

diff --git a/git-annotate.perl b/git-annotate.perl
index feea0a2..6805b8b 100755
--- a/git-annotate.perl
+++ b/git-annotate.perl
@@ -20,7 +20,7 @@ sub usage() {
        -r, --rename
                        Follow renames (Defaults on).
        -S, --rev-file revs-file
-                       use revs from revs-file instead of calling git-rev-list
+                       uses revs from revs-file instead of calling git-rev-list
        -h, --help
                        This message.
 ';
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help