Re: [PATCH 4/4] Read author names and emails from a file

Andreas Ericsson [off-list ref] writes:

Karl Hasselström wrote:

quoted

Read a file with lines on the form
  username User's Full Name [off-list ref]
and use "User's Full Name [off-list ref]" as the GIT author and
committer for Subversion commits made by "username". If encountering a
commit made by a user not in the list, abort.

This is a good thing, but wouldn't it be better to use the same format
as that of cvsimport's -A flag?

If both CVS and SVN have their own native format to express
things like this, and if the format they use are different, then
that is a valid reason for git-{cvs,svn}import to use different
file format.

But if that is not the case, I tend to agree that it might be
easier for users if we had just one format.  I do not think,
however, any single project is likely to have to deal with both
CVS and SVN upstream, importing into the same git repository, so
reusing the mapping file would not be an issue, but having to
learn how to write the mapping just once is a good thing.

I do not offhand recall if SVN has its own native format; if it
has, it may be better to use that, instead of matching what
git-cvsimport does, since I do not think of a reason why the
version with an equal sign is preferrable over the version with
a space.  If the version with '=' were the CVS native format
then that might be a reason to prefer it, but if I recall
correctly that is not the case. so...

On 2006-02-26 21:51:12 -0800, Junio C Hamano wrote:

Andreas Ericsson [off-list ref] writes:

quoted

This is a good thing, but wouldn't it be better to use the same
format as that of cvsimport's -A flag?

If both CVS and SVN have their own native format to express things
like this, and if the format they use are different, then that is a
valid reason for git-{cvs,svn}import to use different file format.

But if that is not the case, I tend to agree that it might be easier
for users if we had just one format. I do not think, however, any
single project is likely to have to deal with both CVS and SVN
upstream, importing into the same git repository, so reusing the
mapping file would not be an issue, but having to learn how to write
the mapping just once is a good thing.

I do not offhand recall if SVN has its own native format; if it has,
it may be better to use that, instead of matching what git-cvsimport
does, since I do not think of a reason why the version with an equal
sign is preferrable over the version with a space. If the version
with '=' were the CVS native format then that might be a reason to
prefer it, but if I recall correctly that is not the case. so...

I don't know of any SVN native format for this, so it seems silly to
use a different format than git-cvsimport. I've also made a patch that
saves the author information, again just like git-cvsimport.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle