DORMANTno replies

[PATCH] Avoid misleading success message on error

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:42:15
Subsystem: the rest · Maintainer: Linus Torvalds

When a push fails (for example when the remote head does not fast forward 
to the desired ref) it is not correct to print "Everything up-to-date".

Signed-off-by: Johannes Schindelin <redacted>

---

 send-pack.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

67819bb187daa5a976bc3d721d5c9f920f52e4ba
diff --git a/send-pack.c b/send-pack.c
index a41bbe5..5bc2f01 100644
--- a/send-pack.c
+++ b/send-pack.c
@@ -272,7 +272,7 @@ static int send_pack(int in, int out, in
 	packet_flush(out);
 	if (new_refs)
 		pack_objects(out, remote_refs);
-	else
+	else if (ret == 0)
 		fprintf(stderr, "Everything up-to-date\n");
 	close(out);
 	return ret;
-- 
0.99.9.GIT
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help