2 messages, 2 authors, 2016-06-15 · open the first message on its own page
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:14
Alex Riesen [off-list ref] writes:
... return MAP_FAILED if error, do not exit process, do no output.
Ah, that is what you meant. I agree.
From: Alex Riesen <hidden>
Date: 2016-06-15 22:42:14
On 12/6/05, Junio C Hamano [off-list ref] wrote:
quoted
... return MAP_FAILED if error, do not exit process, do no output.Ah, that is what you meant. I agree.
now, while we agree, how about the patch removing "user interface" from gitfakemmap altogether? The patch is not really tested (running tests is not useful in this case), but I looked over the call sites, and they seem either to handle mmap's or the previous open's return values. One exception is in config.c where neither is handled, the code will race between stat and open. Signed-off-by: Alex Riesen <redacted>