Re: [PATCH rev-list.c] max-count in terms of intersection

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH rev-list.c] max-count in terms of intersection

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:12

Luben Tuikov [off-list ref] writes:
diff-tree 768b79de9eadc38a839332df0fcce021f7174d6d (from 2e67a5f449f4026097494569f871d79bf263ab28)
tree 6403fc730f8d5843043788f4c2f466727ba94bc0
parent 2e67a5f449f4026097494569f871d79bf263ab28
author Luben Tuikov [off-list ref] 1132349344 -0500
committer Luben Tuikov [off-list ref] 1132349344 -0500

    [PATCH rev-list.c] max-count in terms of intersection
    
Documentation/SubmittingPatches, perhaps?
    When a path designation is given, max-count counts the number
    of commits therein (intersection), not globally.
This makes sense, but I wonder if the same logic applies to
max_age as well.  If we have clock-skewed commits that are
skipped by the DENSE processing, we probably do not want them to
be affecting what to do on the commits that matter.

Re: [PATCH rev-list.c] max-count in terms of intersection

From: Luben Tuikov <hidden>
Date: 2016-06-15 22:42:12

--- Junio C Hamano <junkio@cox.net> wrote:
Luben Tuikov [off-list ref] writes:
quoted
diff-tree 768b79de9eadc38a839332df0fcce021f7174d6d (from
2e67a5f449f4026097494569f871d79bf263ab28)
quoted
tree 6403fc730f8d5843043788f4c2f466727ba94bc0
parent 2e67a5f449f4026097494569f871d79bf263ab28
author Luben Tuikov [off-list ref] 1132349344 -0500
committer Luben Tuikov [off-list ref] 1132349344 -0500

    [PATCH rev-list.c] max-count in terms of intersection
    
Documentation/SubmittingPatches, perhaps?
Sorry, I just saw this document existed for GIT too.
Would you like me to resubmit?
quoted
    When a path designation is given, max-count counts the number
    of commits therein (intersection), not globally.
This makes sense, but I wonder if the same logic applies to
max_age as well.  If we have clock-skewed commits that are
skipped by the DENSE processing, we probably do not want them to
be affecting what to do on the commits that matter.
As far as I understand it, I think max-age is fine the way
it is.  After all, max-age depends on date/time which is
absolute (i.e. applies to commits in the whole set and in
the intersection just the same).

    Luben
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help