Re: [PATCH] specfile cleanups

Chris Wright [off-list ref] writes:

Some specfile cleanups after the split.

Thanks.

Does it matter some Requires use comma and others don't?

-BuildRequires:	zlib-devel, openssl-devel, curl-devel  %{!?_without_docs:, xmlto, asciidoc > 6.0.3}
+BuildRequires:	zlib-devel >= 1.2, openssl-devel, curl-devel  %{!?_without_docs:, xmlto, asciidoc > 6.0.3}
 BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 Requires:	zlib >= 1.2, rsync, rcs, curl, less, openssh-clients, python >= 2.3, tk >= 8.4
 
 Group:          Development/Tools
-Requires:       subversion
+Requires:       git-core = %{version}-%{release} subversion

Junio C Hamano wrote:

Chris Wright [off-list ref] writes:

quoted

Some specfile cleanups after the split.

Thanks.

Does it matter some Requires use comma and others don't?

Other than for consistency reasons, no. Most distributions have it in 
their conventions to use commas. Some don't.

Most also have the conventions enforced by the attached script as it 
enhances readability by removing much un-necessary clutter.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231