Re: [PATCH] Fix empty line processing in git-shortlog.perl

Petr Baudis [off-list ref] writes:

Faced with a commit such as

	commit f1b2646c7f2713c3ea4bce120e1d0d8091808be4
	Author: Adrian Bunk [off-list ref]
	Date:   Sun Nov 6 20:30:38 2005 +0100

	    From: Michal Wronski [off-list ref]

	    I've jchanged my email. Please apply this patch so as to everybody
	    could send me a remarks about mqueuefs.

	    Signed-off-by: Michal Wronski [off-list ref]
	    Signed-off-by: Adrian Bunk [off-list ref]

git-shortlog.perl would produce a line with an empty commit title.

This patch fixes that...

-			next unless /^\s*?(.*)/;
+			next unless /^\s*?(\S.*)$/;

I suspect /(\S.*)$/ would do the same thing, but in any case
I do not think it is the right fix.

I think the problem is deeper than that.  Shortlog summarizes to
only one line per commit, so I suspect what you would be feeding
it would say something like this for the above example:

        commit f1b2646c7f2713c3ea4bce120e1d0d8091808be4
        Author: Adrian Bunk [off-list ref]

            From: Michal Wronski [off-list ref]

That is, the commit you quoted is done by 'git log --pretty',
but a typical shortlog invocation would be:

	git log --pretty=short rev1..rev2 | git shortlog

With or without your fix, the command barfs.

Of course, that "From: " line should have been used as the
commit author by the tool that created the commit out of e-mail
Adrian received, but that is a separate issue.

Dear diary, on Mon, Nov 07, 2005 at 03:56:07AM CET, I got a letter
where Junio C Hamano [off-list ref] told me that...

I think the problem is deeper than that.  Shortlog summarizes to
only one line per commit, so I suspect what you would be feeding
it would say something like this for the above example:

        commit f1b2646c7f2713c3ea4bce120e1d0d8091808be4
        Author: Adrian Bunk [off-list ref]

            From: Michal Wronski [off-list ref]

That is, the commit you quoted is done by 'git log --pretty',
but a typical shortlog invocation would be:

	git log --pretty=short rev1..rev2 | git shortlog

With or without your fix, the command barfs.

Of course, that "From: " line should have been used as the
commit author by the tool that created the commit out of e-mail
Adrian received, but that is a separate issue.

Well, on a second though, I don't think we should probably handle this
at all, then. The whole logic for this in git-shortlog.perl seems to be
dubious, so would be a requirement that we require the input to be from
--pretty=short ok?

Simpler code, no bugs, everyone happy, errors during applying (like
stale From) immediately noticeable.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.