DORMANTno replies

[PATCH] Fix cvsimport warning when called without --no-cvs-direct

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:42:09
Subsystem: the rest · Maintainer: Linus Torvalds

Perl was warning that $opt_p was undefined in that case.

Signed-off-by: Johannes Schindelin <redacted>

---

 git-cvsimport.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applies-to: ba55da41e2670b8728cf911ac7424bc1afeb6ce4
8d4a03322860fcc79cd20b76cb91b2f549cf14fd
diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index 0621dc3..bbb83fb 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -487,7 +487,7 @@ unless($pid) {
 	my @opt;
 	@opt = split(/,/,$opt_p) if defined $opt_p;
 	unshift @opt, '-z', $opt_z if defined $opt_z;
-	unless ($opt_p =~ m/--no-cvs-direct/) {
+	unless (defined($opt_p) && $opt_p =~ m/--no-cvs-direct/) {
 		push @opt, '--cvs-direct';
 	}
 	exec("cvsps",@opt,"-u","-A",'--root',$opt_d,$cvs_tree);
---
0.99.8.GIT
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help