Re: Tool renames.

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: Tool renames.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:06

Junio C Hamano [off-list ref] writes:
"H. Peter Anvin" [off-list ref] writes:
quoted
I noticed you also renamed git-ssh-{push,pull}.  These tools rely on 
having the same names on both sides, so you have introduced a major 
version skew problem.
True.  It seems that both myself and Daniel did not think that
would be a major problem when we were discussing the tool
renames.

As a workaround, you could always say GIT_SSH_PULL='blah' and
GIT_SSH_PUSH='bah' when you run either side to name what will be
run on the other end.
Come to think of it, I should be able to build git-ssh-push and
git-ssh-pull as fully backward compatible way to call the
counterpart with original name, instead of supplying just
symlinks the same way I do currently.  Let me work do that
before I do 0.99.7 this weekend.
Now the interesting problem is if we should rename these
environment variables ...
And the old and new binaries will be built separately anyway, I
could use GIT_SSH_FETCH and GIT_SSH_UPLOAD in the newname
binaries while keeping the old names in oldname binaries.  Ack?

Re: Tool renames.

From: "H. Peter Anvin" <hpa@zytor.com>
Date: 2016-06-15 22:42:06

Junio C Hamano wrote:
Come to think of it, I should be able to build git-ssh-push and
git-ssh-pull as fully backward compatible way to call the
counterpart with original name, instead of supplying just
symlinks the same way I do currently.  Let me work do that
before I do 0.99.7 this weekend.
Better yet, always install the links, and have them use the *old* names 
when calling the remote end.
quoted
Now the interesting problem is if we should rename these
environment variables ...
And the old and new binaries will be built separately anyway, I
could use GIT_SSH_FETCH and GIT_SSH_UPLOAD in the newname
binaries while keeping the old names in oldname binaries.  Ack?
Urk.  Why do this rename anyway?

Typically when doing new environment variables like this you do:

	foo = getenv("NEW_NAME");
	if ( !foo )
		foo = getenv("OLD_NAME");

	-hpa
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help