Re: [PATCH] Make git-apply understand "\ No newline at end of file" in non-english locales

Fredrik Kuivinen [off-list ref] writes:

The message "\ No newline at end of file" which sometimes is produced
by diff(1) is locale dependent. We can't assume more than that it
begins with "\ ".

Signed-off-by: Fredrik Kuivinen <redacted>
---

The previous patch wasn't doing the right thing. Hopefully I have
managed to get it right this time.

I noticed that you left 12 in the previous patch, and thought it
was a sane safety measure to make sure that the incomplete line
marker is of reasonably length, not just any line that starts
with '\ ' (i.e. "\ foobar\n", which is a tad short).

On Sun, Sep 04, 2005 at 12:25:16PM -0700, Junio C Hamano wrote:

Fredrik Kuivinen [off-list ref] writes:

quoted

The message "\ No newline at end of file" which sometimes is produced
by diff(1) is locale dependent. We can't assume more than that it
begins with "\ ".

Signed-off-by: Fredrik Kuivinen <redacted>
---

The previous patch wasn't doing the right thing. Hopefully I have
managed to get it right this time.

I noticed that you left 12 in the previous patch, and thought it
was a sane safety measure to make sure that the incomplete line
marker is of reasonably length, not just any line that starts
with '\ ' (i.e. "\ foobar\n", which is a tad short).

Maybe the first patch wasn't that bad after all :)

In the current diffutils package the Swedish translation is one of the
shortest ones, so 12 is ok for now at least.

- Fredrik