[PATCH] cg-log: cleanup line wrapping by using bash internals
From: Jonas Fonseca <hidden>
Date: 2016-06-15 22:41:59
Subsystem:
the rest · Maintainer:
Linus Torvalds
Use ${#var} instead of echo + wc combo. Additionally also gives
a minor speedup.
Signed-off-by: Jonas Fonseca <redacted>
---
cg-log -f
new code:
real 1m15.462s
user 0m27.195s
sys 0m40.639s
old code:
real 1m38.222s
user 0m32.563s
sys 0m56.034s
BTW, I noticed the following errors:
fatal: internal error in diffcore: unmodified entry remains
fatal: internal error in diffcore: unmodified entry remains
fatal: internal error in diffcore: unmodified entry remains
with both current cogito and git.
To reproduce run either of the following in the cogito repo:
git-diff-tree -r 7c1f9aa894ce91928d982a0b197ab596375825a3 e30dd6c68e576d37bddd011aa7131a6d30297b4c
git-diff-tree -r c49cd3e4f1dfe4ccbf2b8d00188beaa251fee028 9fec8b26eff58e1f595e8619abf1e42c07645ff8
The last one also triggers in the git repo.
The log entries for the two commits are:
commit 6616d1835e81ac0d2304702102d210451c04832a
tree 7c1f9aa894ce91928d982a0b197ab596375825a3
parent e30dd6c68e576d37bddd011aa7131a6d30297b4c
parent e8871e88adca0637eb0299a41d85400beac928bd
author Petr Baudis [off-list ref] Sun, 17 Apr 2005 19:30:32 +0200
committer Petr Baudis <xpasky@machine> Sun, 17 Apr 2005 19:30:32 +0200
Merging: d72ff74f5fd172c6ec9630ee8e08895a0525dcfe
Merge with Linus. Nothing particularily interesting.
commit e44794706eeb57f2ee38ed1604821aa38b8ad9d2
tree c49cd3e4f1dfe4ccbf2b8d00188beaa251fee028
parent 9fec8b26eff58e1f595e8619abf1e42c07645ff8
author Linus Torvalds [off-list ref] Sat, 16 Apr 2005 22:26:31 -0700
committer Linus Torvalds [off-list ref] Sat, 16 Apr 2005 22:26:31 -0700
Be much more liberal about the file mode bits.
We only really care about the difference between a file being executable
or not (by its owner). Everything else we leave for the user umask to
decide.
Any ideas?
cg-log | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cg-log b/cg-log
--- a/cg-log
+++ b/cg-log@@ -129,8 +129,8 @@ list_commit_files() $list_cmd | cut -f 2- | while read file; do echo -n "$sep" sep=", " - if [ $(echo "$line$sep$file" | wc -c) -le 75 ]; then - line="$line$sep$file" + line="$line$sep$file" + if [ "${#line}" -le 74 ]; then echo -n "$file" else line=" $file"
--
Jonas Fonseca