[GIT PATCH] Fix git-mktag to take the object input spliced arbitrarily
From: Petr Baudis <hidden>
Date: 2016-06-15 22:41:58
Before, git-mktag would just try to get all the input through a single read(), which is obviously broken, since the I/O layer may give you only part of the input through such a read(). This made it basically impossible to type the input in manually, for example. Signed-off-by: Petr Baudis <redacted> --- commit f67b8ea0f157813d50371bed494452160c47744d tree e29e13f259279737dd62ca1b10ede1f8d5e2adb8 parent bf36ee6ccc0dae5725edd7f5d56844a0eae158ad author Petr Baudis [off-list ref] Sun, 29 May 2005 01:39:04 +0200 committer Petr Baudis [off-list ref] Sun, 29 May 2005 01:39:04 +0200 mktag.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) Index: mktag.c ===================================================================
--- 01d01f6cebf110348cfa23c86d521118a00336ba/mktag.c (mode:100644)
+++ e29e13f259279737dd62ca1b10ede1f8d5e2adb8/mktag.c (mode:100644)@@ -98,7 +98,7 @@ int main(int argc, char **argv) { - unsigned long size; + unsigned long size, readsize; char buffer[MAXSIZE]; unsigned char result_sha1[20];
@@ -106,7 +106,11 @@ usage("cat <signaturefile> | git-mktag"); // Read the signature - size = read(0, buffer, MAXSIZE); + size = 0; + do { + readsize = read(0, buffer + size, MAXSIZE - size); + size += readsize; + } while (readsize); // Verify it for some basic sanity: it needs to start with "object <sha1>\ntype " if (verify_tag(buffer, size) < 0)
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor